Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: clarify runahead limit #5754

Merged
merged 1 commit into from
Apr 29, 2024
Merged

doc: clarify runahead limit #5754

merged 1 commit into from
Apr 29, 2024

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Oct 4, 2023 •
edited
Loading

The "consecutive" terminology can be a little confusing.

See also cylc/cylc-doc#660

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@oliver-sanders oliver-sanders added the doc Documentation label Oct 4, 2023
@oliver-sanders oliver-sanders added this to the cylc-8.2.2 milestone Oct 4, 2023
@oliver-sanders oliver-sanders self-assigned this Oct 4, 2023
@oliver-sanders oliver-sanders mentioned this pull request Oct 4, 2023
Merged
1 task
@oliver-sanders oliver-sanders modified the milestones: cylc-8.2.2, cylc-8.2.3 Oct 4, 2023
dpmatthews
dpmatthews requested changes Oct 5, 2023
View reviewed changes
dpmatthews
dpmatthews requested changes Oct 11, 2023
View reviewed changes
hjoliver
hjoliver approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, assuming "active cycles" will soon be properly defined in the glossary.

@oliver-sanders oliver-sanders modified the milestones: cylc-8.2.3, cylc-8.2.4 Nov 1, 2023
@oliver-sanders oliver-sanders marked this pull request as draft November 1, 2023 13:14
@oliver-sanders oliver-sanders marked this pull request as ready for review December 14, 2023 17:09
@oliver-sanders oliver-sanders modified the milestones: cylc-8.2.4, 8.2.5 Jan 8, 2024
@oliver-sanders oliver-sanders modified the milestones: cylc-8.2.5, 8.2.x Mar 26, 2024
@hjoliver
Copy link
Member

Let's get this into 8.3.0

@hjoliver hjoliver modified the milestones: 8.2.x, 8.3.0 Apr 29, 2024
@hjoliver hjoliver removed the request for review from dpmatthews April 29, 2024 22:46
@hjoliver hjoliver merged commit f416021 into cylc:master Apr 29, 2024
22 of 25 checks passed
@oliver-sanders oliver-sanders deleted the doc-runahead-limit branch April 30, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpmatthews dpmatthews dpmatthews requested changes

@hjoliver hjoliver hjoliver approved these changes

Assignees

@oliver-sanders oliver-sanders

Labels
doc Documentation
Projects
None yet
Milestone
8.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@oliver-sanders @hjoliver @dpmatthews