workflow-state: query latest task instance #5144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjoliver
force-pushed
the
task-states-flow-nums
branch
from
5a1dfbd to
e37bc89
Compare
hjoliver
changed the title
Comment on lines
+158
to
+159
| # TODO - NEED TO ADD submit_num TO THE task_outputs TABLE SO WE CAN | ||
| # TELL WHICH IS THE LATEST FLOW-INSTANCE (like state_met above). |
Comment on lines
+127
to
+130
| if self.args['status']: | ||
| return self.checker.task_state_met( | ||
| self.args['task'], self.args['cycle'], self.args['status']) | ||
| elif self.args['message']: |
There was a problem hiding this comment.
We should consider erroring if both status and message are defined, otherwise it may look as though this is supported. Or alternatively do both, kinda valid to poll for succeeded plus a custom output e.g. "succeeded with this outcome"?
hjoliver
force-pushed
the
task-states-flow-nums
branch
from
e37bc89 to
63a7fa6
Compare
|
Rebased to 8.0.x |
@hjoliver, can you poke this onto 8.2.x (I think 8.2.x is currently master) |
|
Closing this as superseded by #5809 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a task gets updated in the task states table, update the flow numbers too.
Close #5143
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfgandconda-environment.yml.CHANGES.mdentry included if this is a change that can affect users