Skip to content

Commit

Permalink
Merge pull request #6069 from cylc/8.2.x-sync
Browse files Browse the repository at this point in the history
🤖 Merge 8.2.x-sync into master
  • Loading branch information
wxtim authored Apr 18, 2024
2 parents 4b70574 + 40139b1 commit f9f2455
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 11 deletions.
1 change: 1 addition & 0 deletions changes.d/6068.break.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Removed the Rose Options (`-S`, `-O`, `-D`) from `cylc play`. If you need these use them with `cylc install`.
5 changes: 0 additions & 5 deletions cylc/flow/scheduler.py
Original file line number Diff line number Diff line change
Expand Up @@ -1274,11 +1274,6 @@ def _configure_contact(self) -> None:

def load_flow_file(self, is_reload=False):
"""Load, and log the workflow definition."""
# Local workflow environment set therein.
# Allow -S and -D to take effect in Cylc VR.
# https://github.com/cylc/cylc-flow/issues/5968
self.options.rose_template_vars = []
self.options.defines = []
return WorkflowConfig(
self.workflow,
self.flow_file,
Expand Down
8 changes: 2 additions & 6 deletions cylc/flow/scheduler_cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -309,12 +309,8 @@ def get_option_parser(add_std_opts: bool = False) -> COP:
argdoc=[WORKFLOW_ID_ARG_DOC]
)

options = parser.get_cylc_rose_options() + PLAY_OPTIONS
for option in options:
if isinstance(option, OptionSettings):
parser.add_option(*option.args, **option.kwargs)
else:
parser.add_option(*option['args'], **option['kwargs'])
for option in PLAY_OPTIONS:
parser.add_option(*option.args, **option.kwargs)

if add_std_opts:
# This is for the API wrapper for integration tests. Otherwise (CLI
Expand Down

0 comments on commit f9f2455

Please sign in to comment.