Code review tweaks.

cylc · Jan 30, 2024 · da37214 · da37214
1 parent 4a5eac6
commit da37214
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/cylc/flow/xtriggers/echo.py b/cylc/flow/xtriggers/echo.py
@@ -41,9 +41,7 @@ def validate(f_args, f_kwargs, f_signature):
     This is separate from the xtrigger to allow parse-time validation.
 
     """
-    try:
-        assert type(f_kwargs["succeed"]) is bool
-    except (KeyError, AssertionError):
+    if "succeed" not in f_kwargs or not type(f_kwargs["succeed"]) is bool:
         raise WorkflowConfigError(
-            f"xtrigger requires 'succeed=True/False': {f_signature}"
+            f"Requires 'succeed=True/False' arg: {f_signature}"
         )
diff --git a/cylc/flow/xtriggers/wall_clock.py b/cylc/flow/xtriggers/wall_clock.py
@@ -69,4 +69,4 @@ def validate(f_args, f_kwargs, f_signature):
     try:
         interval_parse(f_kwargs["offset"])
     except ValueError:
-        raise WorkflowConfigError(f": Invalid offset: {f_signature}")
+        raise WorkflowConfigError(f"Invalid offset: {f_signature}")