Skip to content

Commit

Permalink
Response to review
Browse files Browse the repository at this point in the history
Co-authored-by: Ronnie Dutta <[email protected]>
  • Loading branch information
wxtim and MetRonnie committed Oct 30, 2023
1 parent ad511e4 commit 85449a4
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 9 deletions.
5 changes: 1 addition & 4 deletions changes.d/5794.break.md
Original file line number Diff line number Diff line change
@@ -1,4 +1 @@
Remove `cylc report-timings` from automatic installation with
`pip install cylc-flow[all]`. If you now wish to
install it use `pip install cylc-flow[report-timings]`.
Cylc Report timings will no longer work at Python 3.12.
Remove `cylc report-timings` from automatic installation with `pip install cylc-flow[all]`. If you now wish to install it use `pip install cylc-flow[report-timings]`. `cylc report-timings` is incompatible with Python 3.12.
9 changes: 4 additions & 5 deletions cylc/flow/scripts/report_timings.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@
import sys
from typing import TYPE_CHECKING


from cylc.flow import LOG
from cylc.flow.exceptions import CylcError
from cylc.flow.id_cli import parse_id
from cylc.flow.option_parsers import (
Expand Down Expand Up @@ -123,6 +125,8 @@ def main(parser: COP, options: 'Values', workflow_id: str) -> None:
constraint='workflows',
)

LOG.warning('Cylc report-timings is will be retired soon.')

output_options = [
options.show_raw, options.show_summary, options.html_summary
]
Expand Down Expand Up @@ -243,11 +247,6 @@ def write_category(self, buf, category, df_reshape, df_describe):
pass

def _check_imports(self):
if sys.version_info > (3, 11):
raise CylcError(
'Cylc Report Timings is deprecated: It is incompatible'
' with Python > 3.11'
)
try:
import pandas
except ImportError:
Expand Down

0 comments on commit 85449a4

Please sign in to comment.