Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build error #799

Merged
merged 2 commits into from
Feb 18, 2025
Merged

fix build error #799

merged 2 commits into from
Feb 18, 2025

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Feb 18, 2025

  • Sphinx tries to cross-link typing information.
  • If it can't find a type to link to, it will fail in nit-pick mode.
  • If we don't want it to fail, we must list the references in an ignore section.

Example failure: https://github.com/cylc/cylc-doc/actions/runs/13381697432/job/37371236269

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.

* Sphinx tries to cross-link typing information.
* If it can't find a type to link to, it will fail in nit-pick mode.
* If we don't want it to fail, we must list the references in an ignore
  section.
@oliver-sanders oliver-sanders added this to the 8.4.x milestone Feb 18, 2025
@oliver-sanders oliver-sanders self-assigned this Feb 18, 2025
@MetRonnie
Copy link
Member

Not sure why linkcheck is failing since I fixed that link in 16752be

@oliver-sanders
Copy link
Member Author

There's a new linkcheck error resulting from the deletion of cylc-flow tags (which were a convenient way to link the changelog for a release series without having to include the full version number). Will fix on this PR.

@MetRonnie
Copy link
Member

MetRonnie commented Feb 18, 2025

Oh no it's because I did that PR on master (w're talking about the same link)

@MetRonnie MetRonnie merged commit 857be00 into cylc:8.4.x Feb 18, 2025
1 check passed
@oliver-sanders oliver-sanders deleted the fix-missing-type branch February 18, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants