Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system tests #170

Merged
merged 1 commit into from
Apr 24, 2023
Merged

system tests #170

merged 1 commit into from
Apr 24, 2023

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Apr 4, 2023

Sibling: cylc/release-actions#48

  • Partially addresses Nightly Development Builds #33
  • Add a nightly build which installs the Cylc components for each supported Python version. This will help to detect metadata, dependency and branch conflict issues.
  • Future work can add end-to-end tests which engage all of the system components.

This ensures the integrity of the branches.json file. Currently this action is failing due to cylc-rose branch conflict issues which is exactly the sort of error it is meant to flag.

https://github.com/oliver-sanders/cylc-admin/actions/runs/4598273112

new run with the latest diff: https://github.com/oliver-sanders/cylc-admin/actions/runs/4667619014/jobs/8265692353

FYI: The 8.2 tests will fail until - cylc/cylc-rose#219

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

* Partially addresses cylc#33
* Add a nightly build which installs the Cylc components for each
  supported Python version. This will help to detect metadata,
  dependency and branch conflict issues.
* Future work can add end-to-end tests which engage all of the system
  components.
Copy link
Member

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@hjoliver hjoliver force-pushed the master branch 2 times, most recently from 94820ae to 7fc73b8 Compare April 21, 2023 23:44
@oliver-sanders oliver-sanders removed the request for review from hjoliver April 24, 2023 08:57
@oliver-sanders oliver-sanders merged commit 4e77f9b into cylc:master Apr 24, 2023
@oliver-sanders oliver-sanders deleted the system-tests branch April 24, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants