Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default access restrictions of highway=pedestrian, close #393. #421

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix default access restrictions of highway=pedestrian, close #393. #421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24f3a5d
Fix default access restrictions of highway=pedestrian, close #393.
Phyks Aug 8, 2020
db9cf57
Consider a way with bicycle=dismount is the same as bicycle=no.
Phyks Aug 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
* Render `public_transport=platform` + `shelter=yes` as shelter. See #378.
* Render `surface=unpaved` as unknown surface + minor fixes for surfaces.
See #367.
* Fix correct default access restrictions for `highway=pedestrian`. See #393.
* Consider a way with `bicycle=dismount` is equivalent tagging to
`bicycle=no`.


## v0.3.6
Expand Down
8 changes: 4 additions & 4 deletions project.mml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,7 @@ Layer:
ELSE NULL
END AS cycleway_right_oneway,
CASE
WHEN bicycle IN ('no', 'private', 'use_sidepath') THEN 'no'
WHEN bicycle IN ('no', 'dismount', 'private', 'use_sidepath') THEN 'no'
WHEN bicycle IS NOT NULL THEN bicycle
WHEN tags->'motorroad' IN ('yes') THEN 'no'
WHEN highway IN ('motorway', 'motorway_link') THEN 'no'
Expand Down Expand Up @@ -686,7 +686,7 @@ Layer:
ELSE NULL
END AS cycleway_right_oneway,
CASE
WHEN bicycle IN ('no', 'private', 'use_sidepath') THEN 'no'
WHEN bicycle IN ('no', 'dismount', 'private', 'use_sidepath') THEN 'no'
WHEN bicycle IS NOT NULL THEN bicycle
WHEN tags->'motorroad' IN ('yes') THEN 'no'
WHEN highway IN ('motorway', 'motorway_link') THEN 'no'
Expand Down Expand Up @@ -771,7 +771,7 @@ Layer:
END
) AS type,
CASE
WHEN bicycle IN ('no', 'private', 'use_sidepath') THEN 'no'
WHEN bicycle IN ('no', 'dismount', 'private', 'use_sidepath') THEN 'no'
WHEN bicycle IS NOT NULL THEN bicycle
WHEN tags->'motorroad' IN ('yes') THEN 'no'
WHEN highway NOT IN ('motorway', 'motorway_link') AND tags->'vehicle' IN ('no', 'private') THEN 'no'
Expand Down Expand Up @@ -945,7 +945,7 @@ Layer:
ELSE NULL
END AS cycleway_right_oneway,
CASE
WHEN bicycle IN ('no', 'private', 'use_sidepath') THEN 'no'
WHEN bicycle IN ('no', 'dismount', 'private', 'use_sidepath') THEN 'no'
WHEN bicycle IS NOT NULL THEN bicycle
WHEN tags->'motorroad' IN ('yes') THEN 'no'
WHEN highway IN ('motorway', 'motorway_link') THEN 'no'
Expand Down
11 changes: 5 additions & 6 deletions roads.mss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2884,15 +2884,14 @@
// line-color: lighten(@nomotor-fill, 10%);
// }
// }
/* [can_bicycle='no'] {
line-color: @standard-nobicycle;
#tunnel { line-color: lighten(@standard-nobicycle, 5%); }
}*/
/* [cyclestreet='yes'] { // a pedestrian street should not be a cyclestreet
/* [cyclestreet='yes'] { // a pedestrian street should not be a cyclestreet
line-color: @mixed-cycle-fill;
#tunnel { line-color: lighten(@mixed-cycle-fill, 10%); }
}*/
[can_bicycle='no'] {
// Default access for pedestrian is bicycle=dismount
// We need this order to ensure correct overloading of
// bicycle=yes|designated and speed inlines.
[can_bicycle=null], [can_bicycle='no'] {
line-color: @standard-nobicycle;
#tunnel { line-color: lighten(@standard-nobicycle, 5%); }
}
Expand Down