Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement completion #18

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Implement completion #18

merged 2 commits into from
Dec 6, 2024

Conversation

yokaze
Copy link
Contributor

@yokaze yokaze commented Dec 5, 2024 •
edited
Loading

This PR:

  • allows using npv outside of a cluster (as long as it can access Pod IPs directly)
  • implements pod and namespace completion

Signed-off-by: Daichi Sakaue [email protected]

@yokaze yokaze self-assigned this Dec 5, 2024
@yokaze yokaze changed the title Allow using npv outside of a cluster Implement completion Dec 6, 2024
@yokaze yokaze marked this pull request as ready for review December 6, 2024 03:03
@yokaze yokaze requested a review from chez-shanpu December 6, 2024 03:17
yokaze added 2 commits December 6, 2024 12:22
@yokaze
Allow using npv outside of a cluster
45c2683 
Signed-off-by: Daichi Sakaue <[email protected]>
@yokaze
Implement completion
43751d7 
Signed-off-by: Daichi Sakaue <[email protected]>
chez-shanpu
chez-shanpu approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@chez-shanpu chez-shanpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yokaze yokaze merged commit 995d2e4 into main Dec 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chez-shanpu chez-shanpu chez-shanpu approved these changes

Assignees

@yokaze yokaze

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yokaze @chez-shanpu