Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement manifest command #16

Merged
merged 5 commits into from
Nov 25, 2024
Merged

Implement manifest command #16

merged 5 commits into from
Nov 25, 2024

Conversation

yokaze
Copy link
Contributor

@yokaze yokaze commented Nov 20, 2024

This PR implements the following commands:

  • npv manifest generate --from NS/POD --to NS/POD [--ingress OR --egress] [--allow OR --deny] [--name]
    Generate a manifest to allow/deny traffic between the specified pods.
  • npv manifest blast --from NS/POD --to NS/POD
    Display the blast radius of the generated manifest.

@yokaze yokaze mentioned this pull request Nov 20, 2024
@yokaze yokaze changed the title wip wip: Implement manifest command Nov 20, 2024
Signed-off-by: Daichi Sakaue <[email protected]>
@yokaze yokaze changed the title wip: Implement manifest command Implement manifest command Nov 20, 2024
@yokaze yokaze requested a review from chez-shanpu November 20, 2024 08:34
Signed-off-by: Daichi Sakaue <[email protected]>
Copy link
Contributor

@chez-shanpu chez-shanpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work :D
I left some comments.

cmd/npv/app/manifest_blast.go Outdated Show resolved Hide resolved
cmd/npv/app/helper.go Outdated Show resolved Hide resolved
cmd/npv/app/manifest_blast.go Outdated Show resolved Hide resolved
cmd/npv/app/manifest_blast.go Outdated Show resolved Hide resolved
yokaze and others added 2 commits November 22, 2024 10:48
Co-authored-by: Tomoki Sugiura <[email protected]>
Signed-off-by: Daichi Sakaue <[email protected]>
@yokaze yokaze requested a review from chez-shanpu November 22, 2024 04:27
Signed-off-by: Daichi Sakaue <[email protected]>
Copy link
Contributor

@chez-shanpu chez-shanpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yokaze yokaze merged commit 10f88e5 into main Nov 25, 2024
1 check passed
@yokaze yokaze self-assigned this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants