Refactor implementation #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daichi Sakaue <[email protected]>
chez-shanpu
reviewed
Oct 16, 2024
Co-authored-by: Tomoki Sugiura <[email protected]>
Signed-off-by: Daichi Sakaue <[email protected]>
Co-authored-by: Tomoki Sugiura <[email protected]>
Signed-off-by: Daichi Sakaue <[email protected]>
Signed-off-by: Daichi Sakaue <[email protected]>
Signed-off-by: Daichi Sakaue <[email protected]>
chez-shanpu
reviewed
Oct 16, 2024
Comment on lines
+46
to
+56
| ret := strings.Compare(x.Direction, y.Direction) | ||
| if ret == 0 { | ||
| ret = strings.Compare(x.Kind, y.Kind) | ||
| } | ||
| if ret == 0 { | ||
| ret = strings.Compare(x.Namespace, y.Namespace) | ||
| } | ||
| if ret == 0 { | ||
| ret = strings.Compare(x.Name, y.Name) | ||
| } | ||
| return ret < 0 |
There was a problem hiding this comment.
Even if the first ret is negative, it will be overwritten by other string.Compare()?
There was a problem hiding this comment.
@chez-shanpu
It should be blocked by if ret == 0 ?
There was a problem hiding this comment.
@yokaze I was mistaken. thank you :) lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
no-headeroption for table layoutnpv list