Skip to content

Added ESP32 support #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added ESP32 support #77

wants to merge 2 commits into from

Conversation

4lloyd
Copy link

@4lloyd 4lloyd commented May 9, 2019

This PR adds support for the ESP32 module and fixes #48. The changes are tested on an ESP32 Dev Module.

The default IR send pin is 26, but this can be changed in "IRLibESP32.h".

@Humancell
Copy link

Humancell commented Sep 17, 2022

I am curious, is there a reason this PR was not integrated to provide ESP32 support to the project? I'd rather not use a fork, but there are forks that now exist that seem to work. Was there something wrong with the PR?

@nccchirag
Copy link

@4lloyd - Is there a working sample which can be used with the PR?

@4lloyd
Copy link
Author

4lloyd commented Sep 22, 2022

@4lloyd - Is there a working sample which can be used with the PR?

@nccchirag When I made the pull request I used the examples from the library itself to test. I can't remember which examples I have used to test, because I made the changes more then 3 years ago.

@nccchirag
Copy link

@4lloyd - Is there a working sample which can be used with the PR?

@nccchirag When I made the pull request I used the examples from the library itself to test. I can't remember which examples I have used to test, because I made the changes more then 3 years ago.

No problem, thank you so much for the prompt response. Any chance of modifying/enhancing the PR to support latest libraries?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESP32 support?
3 participants