Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

published configs won't have "web" middleware added #36

Merged
merged 11 commits into from
Sep 4, 2024
Merged

published configs won't have "web" middleware added #36

merged 11 commits into from
Sep 4, 2024

Conversation

mszulik
Copy link
Contributor

@mszulik mszulik commented Aug 7, 2024

This is breaking as the web middleware is no longer applied by default.

@mszulik mszulik force-pushed the feature/fully-configurable-route-middleware branch from a1166e1 to d7cc687 Compare August 8, 2024 13:38
@mszulik mszulik added the pullpreview Deploys a preview environment on AWS Lightsail. label Sep 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2024 •
edited
Loading

ssh [email protected]
URL: http://pr-36-fully-configurab-ip-3-67-70-37.my.pullpreview.com:80

@jheusinger
Copy link

jheusinger commented Sep 2, 2024 •
edited
Loading

When defining own Route-Middlewares the default Middlewares will not be applied.

@mszulik mszulik changed the title make it possible to fully configure route middleware own route middleware config won't have "web" added Sep 2, 2024
@mszulik mszulik changed the title own route middleware config won't have "web" added change middleware config behaviour Sep 2, 2024
@mszulik mszulik removed the pullpreview Deploys a preview environment on AWS Lightsail. label Sep 2, 2024
@mszulik mszulik changed the title change middleware config behaviour published configs no longer get web middleware by default Sep 2, 2024
@mszulik mszulik changed the title published configs no longer get web middleware by default published configs no longer get "web" middleware by default Sep 2, 2024
@mszulik mszulik added the pullpreview Deploys a preview environment on AWS Lightsail. label Sep 2, 2024
@mszulik mszulik changed the title published configs no longer get "web" middleware by default published configs won't have "web" middleware added Sep 2, 2024
@mszulik mszulik added pullpreview Deploys a preview environment on AWS Lightsail. and removed pullpreview Deploys a preview environment on AWS Lightsail. labels Sep 2, 2024
@mszulik mszulik added the pullpreview Deploys a preview environment on AWS Lightsail. label Sep 2, 2024
gael-connan-cybex
gael-connan-cybex reviewed Sep 2, 2024
View reviewed changes
Copy link
Contributor

@gael-connan-cybex gael-connan-cybex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested image and video upload, restore and deletion on pullpreview. tested empty, none and configured middleware config behaviour on pullpreview.

gael-connan-cybex
gael-connan-cybex reviewed Sep 2, 2024
View reviewed changes
gael-connan-cybex
gael-connan-cybex reviewed Sep 2, 2024
View reviewed changes
mszulik and others added 2 commits September 3, 2024 07:40
@mszulik @gael-connan-cybex
Update CHANGELOG.md
6005332 
Co-authored-by: Gael Connan <[email protected]>
@mszulik @gael-connan-cybex
Update CHANGELOG.md
155da98 
Co-authored-by: Gael Connan <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024

ssh @
URL:

gael-connan-cybex
gael-connan-cybex approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@gael-connan-cybex gael-connan-cybex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still works on pull preview after middleware change for amigor

@mszulik mszulik merged commit 62bda6f into main Sep 4, 2024
7 checks passed
@mszulik mszulik deleted the feature/fully-configurable-route-middleware branch September 4, 2024 13:31
@github-actions github-actions bot removed the pullpreview Deploys a preview environment on AWS Lightsail. label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gael-connan-cybex gael-connan-cybex Awaiting requested review from gael-connan-cybex

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mszulik @jheusinger @gael-connan-cybex