=table should not be applied on context #2736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raineorshine
requested changes
Dec 26, 2024
raineorshine
approved these changes
Dec 28, 2024
src/components/Thought.tsx
Outdated
Comment on lines
182
to
189
| const isInContextView = useSelector(state => { | ||
| /** Check if the thought is in the context view. */ | ||
| const checkContextView = (currentPath: Path): boolean => { | ||
| if (currentPath.length <= 1) return false | ||
| return isContextViewActive(state, parentOf(currentPath)) | ||
| } | ||
| return checkContextView(path) | ||
| }) |
There was a problem hiding this comment.
This can. be simplified to:
const showContexts = useSelector(state => isContextViewActive(state, rootedParentOf(state, path)))or even:
const showContexts = useSelector(state => isContextViewActive(state, parentOf(path)))There was a problem hiding this comment.
I got it. I will regard that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the issue : Context View: =table should not be applied on context #2724.
In this PR, I have modified the
useHideBulletto not hide bullets(=table) in context view.And I added a function to check if the current thought is in context view.
If the current thougt is in context view, show bullet.