[FEATURE DONE] revo cyberid #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaoPeiwen
reviewed
Sep 16, 2024
| --_supplyCount; | ||
| emit Burn(msg.sender, tokenId); | ||
| for (uint256 i = 0; i < cids.length; i++) { | ||
| _register(cids[i], to, false, cost); |
There was a problem hiding this comment.
就默认不能设置reverse？这个是给用户调的接口吧，是不是也给出来好一点
There was a problem hiding this comment.
确实不能， 不然我给你mint 一个 shabi.cyber
你的地址就会反响解析到 sahbi.cyber
然后这次的产品我问过leo，正好是默认不设置reverse，多发一个tx让用户去设置
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #4 +/- ##
===========================================
- Coverage 82.80% 29.81% -53.00%
===========================================
Files 13 11 -2
Lines 413 369 -44
===========================================
- Hits 342 110 -232
- Misses 71 259 +188 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.