Skip to content

Commit

Permalink
Address CR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
semyon-estrin committed Feb 8, 2022
1 parent 2bf91c0 commit ee63865
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion app/models/policy_version.rb
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ class PolicyVersion < Sequel::Model(:policy_versions)
# The authenticated user who performs the policy load.
many_to_one :role

one_to_many :policy_log, key: [:policy_id, :version]
one_to_many :policy_log, key: %i[policy_id version]

attr_accessor :parse_error, :policy_filename, :delete_permitted

Expand Down
2 changes: 1 addition & 1 deletion cucumber/rotators/features/support/rotator_helpers.rb
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def pg_history_after_rotation(var_name:, db_user:, orig_pw:)
# `PgRotatingPassword` is considered to be `nil`.
#
# This avoids possible race conditions with the actual rotation thread --
# its possible we could "reading" here at the same time the rotation process
# it's possible we could "reading" here at the same time the rotation process
# has only "written" one of the two passwords that need to be kept in sync.
#
PgRotatingPassword ||= Struct.new(:var_name, :db_user, :variable_meth) do
Expand Down

0 comments on commit ee63865

Please sign in to comment.