Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add features to matchups; Fix a bug in player parsing #82

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nabraham
Copy link
Contributor

  • Matchups tell you the winner of each week
  • Matchups tell you if the game is a playoff game (winner's bracket)

- Matchups tell you the winner of each week
- Matchups tell you if the game is a playoff game (winner's bracket)
- Null check the player position dictionary before using it
@codecov-io
Copy link

Codecov Report

Merging #82 into master will decrease coverage by 0.15%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
- Coverage   98.96%   98.81%   -0.16%     
==========================================
  Files          13       13              
  Lines         582      589       +7     
==========================================
+ Hits          576      582       +6     
- Misses          6        7       +1
Impacted Files Coverage Δ
ff_espn_api/league.py 98.2% <100%> (+0.01%) ⬆️
ff_espn_api/matchup.py 94.73% <80%> (-5.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9a45c1...97965b5. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants