Adding type annotation for the scoreboard method #467
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
Team
type annotation for theMatchup
class. Currently, the id is written (as an int) and then in a loop it is dynamically changed to aTeam
. I made a change to store the id in a separate variable_{home,away}_team_id
and then uses that variable in the loop to set theteam
. I noticed this 'issue' while working in VS Code and the type annotation wasn't populating, this should make for a slightly improved developer experience