-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Highlight currently executed instruction in internal editor #138
base: master
Are you sure you want to change the base?
Conversation
fd05990
to
c3ddbb6
Compare
c3ddbb6
to
5e1ee99
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks very good. Good job. But it should be optional. I would like checkboxes in the Options pane to: enable highlighting, and enable focus change. Also a button to trigger the highlight manually would be nice.
One slight nit pick: I would prefer the highlight to cover the whole line (to the right edge of the window), not just the text. To stay consistent with error highlighting.
you mean add a button (for enabling highlighting) at the same time? |
f3282f9
to
6af4d88
Compare
It looks very good. I have just changed some texts. But I have noticed one problem - this does not make that much sense in pipelined settings. Could you hook it up to the focus selection in program view? |
fixed, when machine reload, the connect between machine and editor lost
now rebuild connect between new machine and mainwindow when machine reload:
|
c1b0a9d
to
74abd75
Compare
close #124
when core_step, machine send signal to editor