Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faraday 0.9 compatibility (vcr source from master) #9

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,7 @@ source 'https://rubygems.org'

# Specify your gem's dependencies in kosapi_client.gemspec
gemspec

group :development do
gem 'vcr', github: 'vcr/vcr', branch: 'master'
end
3 changes: 1 addition & 2 deletions kosapi_client.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,13 @@ Gem::Specification.new do |spec|
spec.add_development_dependency 'rspec'
spec.add_development_dependency 'rspec-given'
spec.add_development_dependency 'dotenv'
spec.add_development_dependency 'vcr'
spec.add_development_dependency 'codeclimate-test-reporter'
spec.add_development_dependency 'guard-rspec'
spec.add_development_dependency 'coveralls'
spec.add_development_dependency 'fuubar', '~> 2.0.0.rc1'

spec.add_runtime_dependency 'oauth2'
spec.add_runtime_dependency 'faraday', '~> 0.8.9' # VCR does not work with newer versions yet
spec.add_runtime_dependency 'faraday'
spec.add_runtime_dependency 'activesupport'
spec.add_runtime_dependency 'escape_utils' unless RUBY_PLATFORM == 'java' # used for uri_template
spec.add_runtime_dependency 'uri_template'
Expand Down
2 changes: 1 addition & 1 deletion spec/integration/parallels_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
end

it 'parses timetable slot ID' do
page = client.parallels
page = client.parallels.query('course.code' => 'MI-PAA')
slot = page.items.first.timetable_slots.first
expect(slot.id).not_to be_nil
end
Expand Down