Utilize project-based lookup on individual element access #1812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add utility to backfill lookup table
…oint" This reverts commit 69623cb340e993dc1f86343bd308b9f9d28d57b7.
# Conflicts: # api/main/rest/localization.py # api/main/rest/media.py # api/main/rest/state.py
|
Not complete yet as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds project based access when accessing elements by ID.
This can occur via individual get accesses in REST (e.g.
/rest/Localization/foo), Foreign Key relationships, and ManyToMany relationships.The psuedo-code in any case is
Object.objects.filter(project=foo, id=baz)orObject.object.filter(project=foo,id__in=baz)vsObject.objects.filter(id=baz)orObject.objects.filter(id__in=baz). This was accomplished via adding a ProjectLookup table model which is populated via triggers on editingMedia,State, orLocalizationelements.ForeignKeyField usage was replaced with
ForeignObjectusage which incorporates bothprojectandrelatedin the relationship upon access.ManyToManyFields were replaced with new ManyToManyFields which utilize a custom table and multiple through fields. This allows a similar operation to occur such that
projectis used in any lookup between models where-in it is appropriate and performance-oriented.This PR requires additional migrations which will be backported to
stable