Skip to content

Commit

Permalink
bump to minikube 1.10.1 (1.10 is buggy) and added messages when chart…
Browse files Browse the repository at this point in the history
…museum or kubernetes-dashboard cannot be installed
  • Loading branch information
Christophe VILA committed May 13, 2020
1 parent 78086d9 commit 3e2ead9
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 9 deletions.
8 changes: 5 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
# GoKube Release Notes

## Version 1.10.0 - 05/12/2020
* Bump to minikube 1.10.0
* Bump to helm-spray 4.0.0 (which implies support only for helm 3)
**NOTE: Starting from this version, gokube is only compatible with helm 3**

* Bump to minikube 1.10.1 (1.10 is buggy)
* Bump to helm-spray 4.0.0

## Version 1.9.2 - 04/04/2020
* Bump to minikube 1.9.1
Expand All @@ -24,7 +26,7 @@
* Bump to kubernetes v1.17.2, minikube v1.7.2

## Version 1.8.0 - 12/19/2019
THE BIG ONE
**THE BIG ONE**

* Bump to kubernetes v1.16.4, minikube v1.6.1, helm v2.16.1 and docker 19.03.3
* Support of Virtualbox 6 (with the limitation that no other VMs shall be running during gokube init)
Expand Down
16 changes: 12 additions & 4 deletions cmd/gokube/cmd/init.go
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ func resetVBLease() {
}

func exposeDashboard(port int) {
for n := 1; n < 12; n++ {
for n := 1; n <= 12; n++ {
var dashboardService = kubectl.Get("kubernetes-dashboard", "svc", "kubernetes-dashboard", "")
if len(dashboardService) > 0 {
fmt.Println()
Expand All @@ -167,7 +167,11 @@ func exposeDashboard(port int) {
break
} else {
fmt.Print(".")
time.Sleep(5 * time.Second)
if n == 12 {
fmt.Printf("\nWARNING: kubernetes-dashboard is not present after 60s, which probably means its installation failed")
} else {
time.Sleep(5 * time.Second)
}
}
}
}
Expand All @@ -180,7 +184,7 @@ func configureHelm(localRepoIp string) {
// Install chartmuseum
helm.Upgrade("stable/chartmuseum", "", "chartmuseum", "kube-system", "env.open.DISABLE_API=false,env.open.ALLOW_OVERWRITE=true,service.type=NodePort,service.nodePort=32767", "")
fmt.Printf("Waiting for chartmuseum")
for n := 1; n < 6; n++ {
for n := 1; n <= 12; n++ {
readyReplicas := kubectl.Get("kube-system", "deploy", "chartmuseum-chartmuseum", "{.status.readyReplicas}")
var ready int
if len(readyReplicas) > 0 {
Expand All @@ -196,7 +200,11 @@ func configureHelm(localRepoIp string) {
break
} else {
fmt.Print(".")
time.Sleep(5 * time.Second)
if n == 12 {
fmt.Printf("\nWARNING: chartmuseum is not ready after 60s, which probably means its installation failed")
} else {
time.Sleep(5 * time.Second)
}
}
}
helm.RepoAdd("minikube", "http://"+localRepoIp+":32767")
Expand Down
2 changes: 1 addition & 1 deletion cmd/gokube/cmd/root.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import (
const (
DEFAULT_KUBERNETES_VERSION = "v1.18.2"
DEFAULT_KUBECTL_VERSION = "v1.18.2"
DEFAULT_MINIKUBE_VERSION = "v1.10.0"
DEFAULT_MINIKUBE_VERSION = "v1.10.1"
DEFAULT_MINIKUBE_URL = "https://storage.googleapis.com/minikube/releases/%s/minikube-windows-amd64.exe"
DEFAULT_DOCKER_VERSION = "19.03.8"
DEFAULT_HELM_VERSION = "v3.2.1"
Expand Down
2 changes: 1 addition & 1 deletion cmd/gokube/cmd/version.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ import (
)

const (
GOKUBE_VERSION = "1.10.0-beta.2"
GOKUBE_VERSION = "1.10.0-beta.3"
)

var gokubeVersion string
Expand Down

0 comments on commit 3e2ead9

Please sign in to comment.