Skip to content

Commit

Permalink
Merge pull request #616 from SupianIDz/master
Browse files Browse the repository at this point in the history
Support PHP 8.4
  • Loading branch information
cviebrock authored Nov 29, 2024
2 parents 0f501d5 + f3da8b1 commit 6e79a59
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
strategy:
fail-fast: false
matrix:
php: [8.2, 8.3]
php: [8.2, 8.3, 8.4]
stability: [prefer-lowest, prefer-stable]

name: PHP ${{ matrix.php }} - ${{ matrix.stability }}
Expand Down
4 changes: 2 additions & 2 deletions src/Services/SlugService.php
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ public function getConfiguration(array $overrides = []): array
*
* @return null|string
*/
public function buildSlug(string $attribute, array $config, bool $force = null): ?string
public function buildSlug(string $attribute, array $config, bool $force = false): ?string
{
$slug = $this->model->getAttribute($attribute);

Expand Down Expand Up @@ -407,7 +407,7 @@ protected function usesSoftDeleting(): bool
* @throws \InvalidArgumentException
* @throws \UnexpectedValueException
*/
public static function createSlug($model, string $attribute, string $fromString, array $config = null): string
public static function createSlug($model, string $attribute, string $fromString, ?array $config = null): string
{
if (is_string($model)) {
$model = new $model;
Expand Down
2 changes: 1 addition & 1 deletion src/Sluggable.php
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public static function slugged($callback): void
/**
* @inheritDoc
*/
public function replicate(array $except = null)
public function replicate(?array $except = null)
{
$instance = parent::replicate($except);
(new SlugService())->slug($instance, true);
Expand Down

0 comments on commit 6e79a59

Please sign in to comment.