-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Scannet1500 dataset #25
Open
Phil26AT
wants to merge
4
commits into
main
Choose a base branch
from
scannet1500
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,190 @@ | ||
import logging | ||
import zipfile | ||
from collections import defaultdict | ||
from collections.abc import Iterable | ||
from pathlib import Path | ||
from pprint import pprint | ||
|
||
import matplotlib.pyplot as plt | ||
import numpy as np | ||
import torch | ||
from omegaconf import OmegaConf | ||
from tqdm import tqdm | ||
|
||
from ..datasets import get_dataset | ||
from ..models.cache_loader import CacheLoader | ||
from ..settings import DATA_PATH, EVAL_PATH | ||
from ..utils.export_predictions import export_predictions | ||
from ..visualization.viz2d import plot_cumulative | ||
from .eval_pipeline import EvalPipeline | ||
from .io import get_eval_parser, load_model, parse_eval_args | ||
from .utils import eval_matches_epipolar, eval_poses, eval_relative_pose_robust | ||
|
||
logger = logging.getLogger(__name__) | ||
|
||
|
||
class ScanNet1500Pipeline(EvalPipeline): | ||
default_conf = { | ||
"data": { | ||
"name": "image_pairs", | ||
"pairs": "scannet1500/pairs_calibrated.txt", | ||
"root": "scannet1500/", | ||
"extra_data": "relative_pose", | ||
"preprocessing": { | ||
"side": "long", | ||
}, | ||
"num_workers": 14, | ||
}, | ||
"model": { | ||
"ground_truth": { | ||
"name": None, # remove gt matches | ||
} | ||
}, | ||
"eval": { | ||
"estimator": "opencv", | ||
"ransac_th": 1.0, # -1 runs a bunch of thresholds and selects the best | ||
}, | ||
} | ||
|
||
export_keys = [ | ||
"keypoints0", | ||
"keypoints1", | ||
"keypoint_scores0", | ||
"keypoint_scores1", | ||
"matches0", | ||
"matches1", | ||
"matching_scores0", | ||
"matching_scores1", | ||
] | ||
optional_export_keys = [] | ||
|
||
def _init(self, conf): | ||
if not (DATA_PATH / "scannet1500").exists(): | ||
logger.info("Downloading the MegaDepth-1500 dataset.") | ||
url = "https://cvg-data.inf.ethz.ch/scannet/scannet1500.zip" | ||
Comment on lines
+63
to
+64
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Update logging and download link |
||
zip_path = DATA_PATH / url.rsplit("/", 1)[-1] | ||
zip_path.parent.mkdir(exist_ok=True, parents=True) | ||
torch.hub.download_url_to_file(url, zip_path) | ||
with zipfile.ZipFile(zip_path) as fid: | ||
fid.extractall(DATA_PATH) | ||
zip_path.unlink() | ||
|
||
@classmethod | ||
def get_dataloader(self, data_conf=None): | ||
"""Returns a data loader with samples for each eval datapoint""" | ||
data_conf = data_conf if data_conf else self.default_conf["data"] | ||
dataset = get_dataset(data_conf["name"])(data_conf) | ||
return dataset.get_data_loader("test") | ||
|
||
def get_predictions(self, experiment_dir, model=None, overwrite=False): | ||
"""Export a prediction file for each eval datapoint""" | ||
pred_file = experiment_dir / "predictions.h5" | ||
if not pred_file.exists() or overwrite: | ||
if model is None: | ||
model = load_model(self.conf.model, self.conf.checkpoint) | ||
export_predictions( | ||
self.get_dataloader(self.conf.data), | ||
model, | ||
pred_file, | ||
keys=self.export_keys, | ||
optional_keys=self.optional_export_keys, | ||
) | ||
return pred_file | ||
|
||
def run_eval(self, loader, pred_file): | ||
"""Run the eval on cached predictions""" | ||
conf = self.conf.eval | ||
results = defaultdict(list) | ||
test_thresholds = ( | ||
([conf.ransac_th] if conf.ransac_th > 0 else [0.5, 1.0, 1.5, 2.0, 2.5, 3.0]) | ||
if not isinstance(conf.ransac_th, Iterable) | ||
else conf.ransac_th | ||
) | ||
pose_results = defaultdict(lambda: defaultdict(list)) | ||
cache_loader = CacheLoader({"path": str(pred_file), "collate": None}).eval() | ||
for i, data in enumerate(tqdm(loader)): | ||
pred = cache_loader(data) | ||
# add custom evaluations here | ||
results_i = eval_matches_epipolar(data, pred) | ||
for th in test_thresholds: | ||
pose_results_i = eval_relative_pose_robust( | ||
data, | ||
pred, | ||
{"estimator": conf.estimator, "ransac_th": th}, | ||
) | ||
[pose_results[th][k].append(v) for k, v in pose_results_i.items()] | ||
|
||
# we also store the names for later reference | ||
results_i["names"] = data["name"][0] | ||
if "scene" in data.keys(): | ||
results_i["scenes"] = data["scene"][0] | ||
|
||
for k, v in results_i.items(): | ||
results[k].append(v) | ||
|
||
# summarize results as a dict[str, float] | ||
# you can also add your custom evaluations here | ||
summaries = {} | ||
for k, v in results.items(): | ||
arr = np.array(v) | ||
if not np.issubdtype(np.array(v).dtype, np.number): | ||
continue | ||
summaries[f"m{k}"] = round(np.mean(arr), 3) | ||
|
||
best_pose_results, best_th = eval_poses( | ||
pose_results, auc_ths=[5, 10, 20], key="rel_pose_error" | ||
) | ||
results = {**results, **pose_results[best_th]} | ||
summaries = { | ||
**summaries, | ||
**best_pose_results, | ||
} | ||
|
||
figures = { | ||
"pose_recall": plot_cumulative( | ||
{self.conf.eval.estimator: results["rel_pose_error"]}, | ||
[0, 30], | ||
unit="°", | ||
title="Pose ", | ||
) | ||
} | ||
|
||
return summaries, figures, results | ||
|
||
|
||
if __name__ == "__main__": | ||
from .. import logger # overwrite the logger | ||
|
||
dataset_name = Path(__file__).stem | ||
parser = get_eval_parser() | ||
args = parser.parse_intermixed_args() | ||
|
||
default_conf = OmegaConf.create(ScanNet1500Pipeline.default_conf) | ||
|
||
# mingle paths | ||
output_dir = Path(EVAL_PATH, dataset_name) | ||
output_dir.mkdir(exist_ok=True, parents=True) | ||
|
||
name, conf = parse_eval_args( | ||
dataset_name, | ||
args, | ||
"configs/", | ||
default_conf, | ||
) | ||
|
||
experiment_dir = output_dir / name | ||
experiment_dir.mkdir(exist_ok=True) | ||
|
||
pipeline = ScanNet1500Pipeline(conf) | ||
s, f, r = pipeline.run( | ||
experiment_dir, | ||
overwrite=args.overwrite, | ||
overwrite_eval=args.overwrite_eval, | ||
) | ||
|
||
pprint(s) | ||
|
||
if args.plot: | ||
for name, fig in f.items(): | ||
fig.canvas.manager.set_window_title(name) | ||
plt.show() |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: add PoseLib