Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to the new pycolmap interface #446

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

B1ueber2y
Copy link
Member

@B1ueber2y B1ueber2y commented Dec 12, 2024

Fixes #440
Fixes #438

@B1ueber2y B1ueber2y marked this pull request as draft December 12, 2024 16:05
@B1ueber2y B1ueber2y marked this pull request as draft December 16, 2024 08:13
@B1ueber2y B1ueber2y marked this pull request as ready for review December 16, 2024 08:33
@plusk01
Copy link

plusk01 commented Dec 25, 2024

visualization.py

selected = random.Random(seed).sample(image_ids, min(n, len(image_ids)))

complains with TypeError: Population must be a sequence. For dicts or sets, use sorted(d).

due to colmap/colmap@d8b50eb#diff-41d77a1f9328d7e0ee226222fcfa320cf1c503f73f6e43c764a8be80a1c66c79R302

can you add sorted(image_ids) to this PR?

@B1ueber2y
Copy link
Member Author

B1ueber2y commented Dec 25, 2024

visualization.py

selected = random.Random(seed).sample(image_ids, min(n, len(image_ids)))

complains with TypeError: Population must be a sequence. For dicts or sets, use sorted(d).

due to colmap/colmap@d8b50eb#diff-41d77a1f9328d7e0ee226222fcfa320cf1c503f73f6e43c764a8be80a1c66c79R302

can you add sorted(image_ids) to this PR?

Thanks. This is fixed: 13cfc88.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants