Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposed ALIKED feature extractor from LightGlue #375

Merged
merged 4 commits into from
Nov 3, 2024
Merged

Conversation

Dawars
Copy link
Contributor

@Dawars Dawars commented Mar 6, 2024

I exposed the ALIKED feature extractor from LightGlue. I added two versions: feats-aliked-n16-rot and feats-aliked-n32.

Should I expose all variants?

Matching is possible via LightGlue by using aliked+lightglue.

If you would like me to make some changes please let me know.

@ArneSchulzTUBS
Copy link

Thanks for providing this implementation!

I had to do one small adjustment to get it running: There is a typo in the model_name feature_extractor configuration of aliked-n16-rot:
The model_name is set to aliked-n16-rot

"model_name": "aliked-n16-rot",

while the ALIKED implementation is using the model_name aliked-n16rot
https://github.com/cvg/LightGlue/blob/edb2b838efb2ecfe3f88097c5fad9887d95aedad/lightglue/aliked.py#L628

@sarlinpe
Copy link
Member

sarlinpe commented Nov 3, 2024

Thank you both!

@sarlinpe sarlinpe merged commit abb2520 into cvg:master Nov 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants