Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding pairs from sequence #175

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cduguet
Copy link

@cduguet cduguet commented Mar 30, 2022

For faster SfM from video frames, and since it was mentioned in #135, I made a small image pair generator based on pairs_from_exhaustive. It has a window size, meaning image i can be paired with many up to i+window, and a loop option, meaning the last image can be paired with the first one.

@sarlinpe
Copy link
Member

sarlinpe commented Apr 4, 2022

Thank you very much for this contribution! COLMAP has a sequential matcher that also has:

  • quadratic overlap: match images in i + 2**[0, window] as well
  • loop closure: trigger retrieval every n frames

Are you interested in implementing these features? I think that they could improve the accuracy & robustness on video data.

@cduguet
Copy link
Author

cduguet commented Apr 5, 2022

sure thing, it's a great idea! adding to my todo list.

@zr19980402
Copy link

Could you finish the sequential matcher? I have the same interest in it.

@awarebayes
Copy link

Same thing would be real nice

@awarebayes
Copy link

Good implementation with loop closing and retrieval can be found in this fork: https://gitlab.ethz.ch/z-ricityslam/hloc_fork

@zr19980402
Copy link

zr19980402 commented Mar 21, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants