Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nightly tests #8496

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
+14 −8
Open

fix nightly tests #8496

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac37d42
Fixed image tags
azhavoro Oct 1, 2024
837dc3e
Split rest and unit tests into different steps
azhavoro Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions .github/workflows/schedule.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ jobs:
context: .
file: ./Dockerfile.ui
cache-from: type=local,src=/tmp/cvat_cache_ui
tags: cvat/ui:latest
tags: cvat/ui:dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this image actually used for anything? It seems like the UI doesn't actually get started at any point in this job.

And if it is needed, wouldn't it make more sense to pull the image that's already been built, instead of building it anew?

load: true

- name: CVAT server. Extract metadata (tags, labels) for Docker
Expand All @@ -147,9 +147,9 @@ jobs:
- name: Pull CVAT server image
run: |
docker pull ${{ steps.meta-server.outputs.tags }}
docker tag ${{ steps.meta-server.outputs.tags }} cvat/server:dev
#TODO fix tag in Dockerfile.ci
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you elaborate? What do you want to fix?

docker tag ${{ steps.meta-server.outputs.tags }} cvat/server:local
docker tag ${{ steps.meta-server.outputs.tags }} cvat/server:latest
docker tag cvat/ui:latest cvat/ui:local

- name: OPA tests
run: |
Expand All @@ -158,15 +158,21 @@ jobs:
docker compose run --rm -v "$PWD:/mnt/src:ro" -w /mnt/src \
cvat_opa test cvat/apps/*/rules

- name: REST API and SDK tests
- name: Generate SDK
run: |
pip3 install -r cvat-sdk/gen/requirements.txt
./cvat-sdk/gen/generate.sh

pip3 install -r ./tests/python/requirements.txt
pip3 install -e ./cvat-sdk
pip3 install -e ./cvat-cli
- name: Install test dependencies, SDK and CLI
run: |
pip3 install \
-r ./tests/python/requirements.txt \
-e './cvat-sdk[pytorch]' \
-e ./cvat-cli \
--extra-index-url https://download.pytorch.org/whl/cpu

- name: Run REST API and SDK tests
run: |
pytest tests/python/
pytest tests/python/ --stop-services

Expand All @@ -176,7 +182,7 @@ jobs:
CVAT_ALLOW_STATIC_CACHE="true" pytest tests/python
pytest tests/python/ --stop-services

- name: Unit tests
- name: Run unit tests
env:
HOST_COVERAGE_DATA_DIR: ${{ github.workspace }}
CONTAINER_COVERAGE_DATA_DIR: "/coverage_data"
Expand Down
Loading