using coderabbit suggestions

cvat-ai · Oct 4, 2024 · 4395c3c · 4395c3c
1 parent b18cb2f
commit 4395c3c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/cvat/apps/engine/serializers.py b/cvat/apps/engine/serializers.py
@@ -225,9 +225,7 @@ class Meta:
 class UserSerializer(serializers.ModelSerializer):
     groups = serializers.SlugRelatedField(many=True,
         slug_field='name', queryset=Group.objects.all())
-    has_analytics_access = serializers.SlugRelatedField(
-        source='profile', many=False, slug_field='has_analytics_access', read_only=True,
-    )
+    has_analytics_access = serializers.BooleanField(source='profile.has_analytics_access')
 
     class Meta:
         model = User

diff --git a/cvat/apps/iam/permissions.py b/cvat/apps/iam/permissions.py
@@ -273,8 +273,8 @@ def is_metadata_request(request, view):
 class IsAuthenticatedOrReadPublicResource(BasePermission):
     def has_object_permission(self, request, view, obj) -> bool:
         return bool(
-            request.user and request.user.is_authenticated or
-            request.method == 'GET' and is_public_obj(obj)
+            (request.user and request.user.is_authenticated) or
+            (request.method == 'GET' and is_public_obj(obj))
         )