fix: exclude verify type of RegExp #112
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add exclude verify type of RegExp:
if exclude type is Function, it has a bug
eg:
postCssPxToRem({
exclude: (filePath) => {
const reg = /src/pages/m|src/components/m|share/components/m/;
return !reg.test(filePath);
},
})
if we got a filePath: '/project/src/components/m/Button.scss', exclude(filePath) return false, but isExcludeFile will be true;
because filePath.match(exclude) !== null
if we pass a function to math, it will be potential risks:
console.log('abc'.match(() => { const reg = /a|b|c/; }))