-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/Support for other Sage Accounting API endpoints #3
Draft
ZainIftikhar7vals
wants to merge
18
commits into
customersure:master
Choose a base branch
from
ZainIftikhar7vals:feature/add_support_for_other_SBCA_api_endpoints
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Feature/Support for other Sage Accounting API endpoints #3
ZainIftikhar7vals
wants to merge
18
commits into
customersure:master
from
ZainIftikhar7vals:feature/add_support_for_other_SBCA_api_endpoints
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es_invoices, services, stock_items, stock_movements and tax_rates API endpoints and moved them under module V3 as for API V2 endpoints are different
…token method to use application/x-www-form-urlencoded as content tpye while making request
@@ -47,6 +48,17 @@ def request(method, path, options) | |||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add comment: by default auto_traversal is true hence index data will be loaded at once in memory
:request_host, | ||
:auto_traversal, | ||
:raw_response].freeze | ||
VALID_OPTIONS_KEYS = %i[ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
segregate dynamic and static attributes if possible
…unts API endpoints
…d while calling sales_invoices end point for a specfic invoice
…ested hash into correctly formatted "date strings", now this method will aslo check if hash value is an array then it will loop on each element and calls format_datelike_objects if and only if its an hash
…lso sent business_id in header of each request
…eneric ClientError exception for 4xx http status codes for which specfic exception class is not defined and raised ServerError for 5xx http status codes for which specfic exception class is not defined
…lue using is_a? used case statement defaul implementation
…ntains remaining data and load it, this procedure will be repeated recursively until all data is loaded
…heck before fetching next_link from response body
…ror":"invalid_grant","error_description":"the submitted refresh_token is invalid"}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated GEM For Sage Accounting API V3.1 and Added Support for All other available API endpoints.