rename custom events

customcommander · Sep 27, 2024 · ccec185 · ccec185
1 parent 41a91f3
commit ccec185
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 12 deletions.
diff --git a/src/component-app.js b/src/component-app.js
@@ -88,9 +88,8 @@ class App extends LitElement {
       mechanism for several other observables
       so the emission needs to be multicasted.
 
-      TODO: rename `game.restart`
      */
-    this._restart$ = fromEvent(this, 'restart-game').pipe(
+    this._restart$ = fromEvent(this, 'game.restart').pipe(
       map(() => true),
       share()
     );
@@ -102,7 +101,7 @@ class App extends LitElement {
       1. From playing the game.
 
       The player moves are dispatched through a dedicated
-      CustomEvent channel `player.move` (TODO: rename).
+      CustomEvent channel `player.move`.
 
       This observable subscribes to that channel.
 
@@ -128,13 +127,10 @@ class App extends LitElement {
       })
     );
 
-    // TODO: rename to `player.move`.
-    //       allow to unsubscribe from it.
-    fromEvent(this, 'dispatch')
+    fromEvent(this, 'player.move')
       .pipe(map(ev => ev.detail))
       .subscribe(this._event$);
 
-
     /*
 
       This emits only after a player has decided

diff --git a/src/component-error.js b/src/component-error.js
@@ -40,7 +40,7 @@ class Err extends LitElement {
 
   _dismiss() {
     this.dispatchEvent(
-      new CustomEvent('dispatch', {
+      new CustomEvent('player.move', {
         bubbles: true,
         composed: true,
         detail: {

diff --git a/src/component-farmyard.js b/src/component-farmyard.js
@@ -99,7 +99,7 @@ class FarmYard extends LitElement {
 
   _dispatch(sel) {
     this.dispatchEvent(
-      new CustomEvent('dispatch', {
+      new CustomEvent('player.move', {
         bubbles: true,
         composed: true,
         detail: sel

diff --git a/src/component-footer.js b/src/component-footer.js
@@ -14,7 +14,7 @@ class AgricolaFooter extends LitElement {
 
   _restart() {
     this.dispatchEvent(
-      new CustomEvent('restart-game', {
+      new CustomEvent('game.restart', {
         bubbles: true,
         composed: true
       })

diff --git a/src/component-infobar.js b/src/component-infobar.js
@@ -26,7 +26,7 @@ class InfoBar extends LitElement {
 
   _dispatch(task_id) {
     this.dispatchEvent(
-      new CustomEvent('dispatch', {
+      new CustomEvent('player.move', {
         bubbles: true,
         composed: true,
         detail: {

diff --git a/src/component-tasks.js b/src/component-tasks.js
@@ -93,7 +93,7 @@ class Tasks extends LitElement {
 
   _notify(task_id) {
     this.dispatchEvent(
-      new CustomEvent('dispatch', {
+      new CustomEvent('player.move', {
         bubbles: true,
         composed: true,
         detail: {