Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #438: Fix import-path of CurrencyMismatch #446

Closed

Conversation

Newspaperman57
Copy link

@Newspaperman57 Newspaperman57 commented Nov 7, 2024

Fixed the import-path of CurrencyMismatch from base -> elspot, based on recommendation of the author in this issue, and pinned the nordpool-package to >=0.4.3,<1 to avoid jumping major versions in the future.

A lot of users are affected since the release of 2024.11, many will be upgrading their homeassistant-instance, and therefore the nordpool package - this is what happened to me.

I believe this is a better fix than PR #439

Tested in my private homeassistant

Fixes issue #438

@Newspaperman57 Newspaperman57 changed the title Issue #443: Fix import-path of CurrencyMismatch Issue #438: Fix import-path of CurrencyMismatch Nov 7, 2024
Copy link

@cagemaan cagemaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested the changes on my own HA running core 2024.10.4

@developerfromjokela
Copy link
Contributor

Fixed the import-path of CurrencyMismatch from base -> elspot, based on recommendation of the author in this issue, and pinned the nordpool-package to >=0.4.3,<1 to avoid jumping major versions in the future.

A lot of users are affected since the release of 2024.11, many will be upgrading their homeassistant-instance, and therefore the nordpool package - this is what happened to me.

I believe this is a better fix than PR #439

Tested in my private homeassistant

Fixes issue #438

About being a better fix, imo whole library is really useless for this project. For future, I think it would be beneficial to stop relying on that library completely. It's mainly imported for classes, exceptions, etc. Almost nothing is imported for the actual logic. Most methods are overriden anyways by this library, especially after new API update.

@Hellowlol
Copy link
Collaborator

Thanks for the PR, but i decided to merge the other fix instead. I think we should just remove the nordpool dependancy. As @developerfromjokela mentioned. We really dont need much from it anyway, the reason for using it more for historical reasons as i contributed the async API to the nordpool package, but it wasnt merged in the package at the time.

@Hellowlol Hellowlol closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants