-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to work as an async Integration #48
Conversation
Sync methods changed to work in async manner where possible. Calls to Sony_bravia_psk achieved using hass_async_ass_executor_job.
Thanks for the PR. Will have a look at it asap and can release it as a beta for testing. |
I think I've checked all the methods I changed. I've also run all the relevant services against it. Worth a double check though. |
I will merge the PR in the |
How to test beta? Trying to add the link https://github.com/custom-components/media_player.braviatv_psk/tree/dev_async manually fails with: I guess I haven't tried removing the original repository yet but technically those are different repos so it's weird that it would be needed. |
Go to reinstall integration, it will then show you versions, and a toggle switch for betas. |
As Roger says, there is no need to add a custom repository nor to remove the current one. |
@RogerSelwyn I see some messages every now and then in the logs @rchl were you already able to do some testing? |
I agree, not perfect, but better. |
@gerard33 it all appears to work for me just fine. |
Sync methods changed to work in async manner where possible. Calls to Sony_bravia_psk achieved using hass_async_ass_executor_job.