Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to work as an async Integration #48

Merged
merged 2 commits into from
Mar 6, 2021
Merged

Update to work as an async Integration #48

merged 2 commits into from
Mar 6, 2021

Conversation

RogerSelwyn
Copy link
Contributor

Sync methods changed to work in async manner where possible. Calls to Sony_bravia_psk achieved using hass_async_ass_executor_job.

Sync methods changed to work in async manner where possible. Calls to Sony_bravia_psk achieved using hass_async_ass_executor_job.
@gerard33
Copy link
Member

gerard33 commented Mar 2, 2021

Thanks for the PR. Will have a look at it asap and can release it as a beta for testing.

@RogerSelwyn
Copy link
Contributor Author

I think I've checked all the methods I changed. I've also run all the relevant services against it. Worth a double check though.

@gerard33 gerard33 changed the base branch from master to dev_async March 6, 2021 21:05
@gerard33
Copy link
Member

gerard33 commented Mar 6, 2021

I will merge the PR in the dev_async branch and will make a beta release for testing.

@gerard33 gerard33 merged commit 3ada8e7 into custom-components:dev_async Mar 6, 2021
@rchl
Copy link
Contributor

rchl commented Mar 7, 2021

How to test beta?

Trying to add the link https://github.com/custom-components/media_player.braviatv_psk/tree/dev_async manually fails with:

Screenshot 2021-03-07 at 21 53 43

I guess I haven't tried removing the original repository yet but technically those are different repos so it's weird that it would be needed.

@RogerSelwyn
Copy link
Contributor Author

Go to reinstall integration, it will then show you versions, and a toggle switch for betas.

@gerard33
Copy link
Member

gerard33 commented Mar 7, 2021

As Roger says, there is no need to add a custom repository nor to remove the current one.

@gerard33
Copy link
Member

@RogerSelwyn I see some messages every now and then in the logs Updating braviatv_psk media_player took longer than the scheduled update interval 0:00:10
but definitely a lot less than before 👍

@rchl were you already able to do some testing?

@RogerSelwyn
Copy link
Contributor Author

I agree, not perfect, but better.

@rchl
Copy link
Contributor

rchl commented Mar 13, 2021

@gerard33 it all appears to work for me just fine.

@RogerSelwyn RogerSelwyn deleted the patch-1 branch March 27, 2021 18:36
gerard33 added a commit that referenced this pull request Apr 5, 2021
* Update to work as an async Integration

Sync methods changed to work in async manner where possible. Calls to Sony_bravia_psk achieved using hass_async_ass_executor_job.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants