-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored tests #55
Open
heswithme
wants to merge
49
commits into
curvefi:main
Choose a base branch
from
heswithme:test/fixed-testsuite
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Refactored tests #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heswithme
requested review from
DanielSchiavini,
bout3fiddy and
AlbertoCentonze
September 27, 2024 16:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Goal: Make all tests pass.
Ways to achieve: Go through each failing test and figure out failure reason, attempt to fix
Files changed: Almost every test_*.py was altered in one way or another, some more, some less.
List of changes:
This PR ensures the existing test suite passes, while not explicitly introducing new test functions/scenarios.
Comparison
One of initial test run reports vs. Latest test run report
Significant increase in test amounts is related to enabling extensive token pair search (i.e. plain+rebasing != rebasing+plain).
Expected improvement: