Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show better exception message when vscode settings json is not found #2655

Merged
merged 3 commits into from
Aug 17, 2024

Conversation

AndreasArvidsson
Copy link
Member

Today you get a ValueError: max() arg is an empty sequence message that is quite confusing.

Checklist

  • [/] I have added tests
  • [/] I have updated the docs and cheatsheet
  • [/] I have not broken the cheatsheet

@AndreasArvidsson AndreasArvidsson requested a review from a team as a code owner August 16, 2024 08:49
cursorless-talon/src/apps/vscode_settings.py Outdated Show resolved Hide resolved
@AndreasArvidsson AndreasArvidsson added this pull request to the merge queue Aug 17, 2024
Merged via the queue into main with commit 49f7084 Aug 17, 2024
15 checks passed
@AndreasArvidsson AndreasArvidsson deleted the settingsJsonError branch August 17, 2024 23:17
cursorless-bot pushed a commit that referenced this pull request Aug 17, 2024
…2655)

Today you get a `ValueError: max() arg is an empty sequence` message
that is quite confusing.

## Checklist

- [/] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [/] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [/] I have not broken the cheatsheet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants