Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace firstNonWhitespaceCharacterIndex with rangeTrimmed #2534

Merged
merged 16 commits into from
Aug 3, 2024
Merged

Replace firstNonWhitespaceCharacterIndex with rangeTrimmed #2534

merged 16 commits into from
Aug 3, 2024

Conversation

AndreasArvidsson
Copy link
Member

@AndreasArvidsson AndreasArvidsson commented Jul 19, 2024 •
edited
Loading

Fixes #2519

Checklist

  • [/] I have added tests
  • [/] I have updated the docs and cheatsheet
  • [/] I have not broken the cheatsheet

@AndreasArvidsson AndreasArvidsson requested a review from pokey as a code owner July 19, 2024 01:47
@pokey pokey requested a review from a team as a code owner July 28, 2024 15:22
pokey
pokey reviewed Jul 28, 2024
View reviewed changes
Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure bout this one; see comments

@AndreasArvidsson AndreasArvidsson added the to discuss Plan to discuss at meet-up label Jul 28, 2024
@pokey pokey removed the to discuss Plan to discuss at meet-up label Aug 1, 2024
@AndreasArvidsson
Copy link
Member Author

Updated with undefined if the range is empty or whitespace.

@AndreasArvidsson AndreasArvidsson added this pull request to the merge queue Aug 3, 2024
Merged via the queue into main with commit adf6ba9 Aug 3, 2024
15 checks passed
@AndreasArvidsson AndreasArvidsson deleted the rangeTrimmed branch August 3, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pokey pokey pokey left review comments

@phillco phillco phillco approved these changes

@saidelike saidelike Awaiting requested review from saidelike saidelike is a code owner

@fidgetingbits fidgetingbits Awaiting requested review from fidgetingbits fidgetingbits is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace poorly named firstNonWhitespaceCharacterIndex and lastNonWhitespaceCharacterIndex
3 participants
@AndreasArvidsson @phillco @pokey