Fix FontMeasurementsImpl to work in a web environment #2260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
February 7, 2024 11:45
|
/cc @wolfmanstout |
pokey
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FontMeasurementsImpl currently uses an inline script to compute font size ratios which is not compatible with a web environment due to Content Security Policy (CSP) rules. This PR switches to a separate script file and adds a CSP rule for it according to the instructions in https://code.visualstudio.com/api/extension-guides/webview#content-security-policy.
To test, change the
Editor: Font Familysetting (you can just append, xto the end or make any other change). Success is seeing a tab flash and disappear; failure is the tab showing "Loading Cursorless..." remaining open.