Added spread support for relative and ordinal scopes #2254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
update from meet-up:
|
|
Updated! |
pokey
reviewed
Mar 12, 2024
packages/common/src/types/command/PartialTargetDescriptor.types.ts
Outdated
Show resolved
Hide resolved
packages/cursorless-engine/src/processTargets/modifiers/targetSequenceUtils.ts
Outdated
Show resolved
Hide resolved
packages/cursorless-engine/src/processTargets/modifiers/targetSequenceUtils.ts
Outdated
Show resolved
Hide resolved
pokey
reviewed
Mar 14, 2024
pokey
approved these changes
Mar 24, 2024
|
pokey
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
ok should be good to go @AndreasArvidsson ! Was a good thing I updated cheatsheet—turns out it was broken due to the fact you factored simple_modifier into two lists 😬
here are my changes in case helpful: https://github.com/cursorless-dev/cursorless/pull/2254/files/ac0bc761fda6621b7d7748fea98be34f90d86650..5ba078aff4cbc10d01508fd49a2f91899ecc727b
cursorless-bot
pushed a commit
that referenced
this pull request
Mar 25, 2024
`"change every two tokens"` Fixes #1514 ## Checklist - [x] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [x] I have updated the [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [x] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) - [x] I have not broken the cheatsheet --------- Co-authored-by: Pokey Rule <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"change every two tokens"Fixes #1514
Checklist