-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fallback to Talon actions when focus is not on the text editor #2235
Conversation
notes from meet-up:
|
I bailed on this. We don't even have the complete target, just a partial one. Since we're not inside the pipeline yet using the api probably is the sensible thing. I did switch to a fixed version numbers we don't have to keep updating this for every new api version. |
@pokey Recording test was unfortunately not as easy as we assumed. We never actually run the command runner when we do a fallback. ergo the test case recorder is never called. cursorless/packages/cursorless-engine/src/runCommand.ts Lines 83 to 89 in 407dc94
|
done |
I haven't noticed any problems |
I haven't noticed any problem either fwiw |
Not sure if you want to include it in this PR but I added support for
|
|
pre and post fallback actions added |
Ok I did some profiling, and it's actually my |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Edit operations supported by community will now work in vscode outside of the text editor. eg the search widget `take line` `chuck token` Everything appears to be working when I have tested it. With that said I have not tested on community and we should probably have a discussion about some of the finer details of this. ## Checklist - [x] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [ ] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [x] I have not broken the cheatsheet --------- Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com> Co-authored-by: Pokey Rule <[email protected]>
Looks like these broke in #2235 ## Checklist - [-] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [-] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [-] I have not broken the cheatsheet
This was not caught by our tests because we mock away command server. Not sure how to prevent this sort of thing in the future
This was not caught by our tests because we mock away command server. Not sure how to prevent this sort of thing in the future
This was not caught by our tests because we mock away command server. Not sure how to prevent this sort of thing in the future
This was not caught by our tests because we mock away command server. Not sure how to prevent this sort of thing in the future
This was not caught by our tests because we mock away command server. Not sure how catch this sort of thing in our tests; it's one of the hazards of mocking This PR introduces a more robust approach, where `undefined` means that we don't know which element is focused, either because there is no command server, or we have not been called by the command server - See also cursorless-dev/command-server#25 ## Checklist - [-] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [-] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [-] I have not broken the cheatsheet
Edit operations supported by community will now work in vscode outside of the text editor. eg the search widget
take line
chuck token
Everything appears to be working when I have tested it. With that said I have not tested on community and we should probably have a discussion about some of the finer details of this.
Checklist