Convert VscodeHatRendered to use vscode.workspace.fs #2194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er.ts Log cannot watch hatsDir exception. Co-authored-by: David Vo <[email protected]>
pokey
reviewed
Jan 23, 2024
There was a problem hiding this comment.
looks good, but @AndreasArvidsson maybe you'd like to test locally to make sure it doesn't break your custom hats? I don't use custom hats
|
I assume @bjaspan has tested it already? |
|
It works well enough for me in the web-based VSCode inside Google to load and display standard hats. I don't use custom hats, either, and they wouldn't work (yet) in the web environment since that part of the code still uses |
|
I'll test locally just to ensure that normal hats don't break, but I won't test custom hats because that's not an officially supported feature. @AndreasArvidsson I guess you can file an issue if custom hats break |
pokey
approved these changes
Jan 25, 2024
pokey
pushed a commit
that referenced
this pull request
Jan 31, 2024
This is part of porting Cursorless to work in the web environment. This is a re-roll of #2153 which I messed up with bad git-fu. ## Checklist - [ ] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [ ] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [ ] I have not broken the cheatsheet --------- Co-authored-by: Barry Jaspan <[email protected]> Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com> Co-authored-by: David Vo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of porting Cursorless to work in the web environment.
This is a re-roll of #2153 which I messed up with bad git-fu.
Checklist