Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add simple command history analyzer #2163

Merged
merged 9 commits into from
Feb 1, 2024
Merged

Add simple command history analyzer #2163

merged 9 commits into from
Feb 1, 2024

Conversation

AndreasArvidsson
Copy link
Member

@AndreasArvidsson AndreasArvidsson commented Jan 3, 2024 •
edited by pokey
Loading

image

Checklist

@pokey pokey force-pushed the andreas/simple-command-history-analyzer branch from 8925901 to 2c5f501 Compare January 26, 2024 15:48
pokey
pokey approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I did some cleanup. Merge if you're happy!

@pokey
Copy link
Member

pokey commented Jan 31, 2024

Ok I did the following:

  • Added a totals section before the month-by-month. Tbh I'm not sure the month-by-month is helpful
  • Added percentages to each line
  • Added a voice command and quick docs blurb
  • Added code to handle the case where they have no history

If you're happy feel free to merge

@AndreasArvidsson AndreasArvidsson added this pull request to the merge queue Feb 1, 2024
Merged via the queue into main with commit be6ab53 Feb 1, 2024
14 checks passed
@AndreasArvidsson AndreasArvidsson deleted the andreas/simple-command-history-analyzer branch February 1, 2024 12:53
cursorless-bot pushed a commit that referenced this pull request Feb 1, 2024
@AndreasArvidsson @pokey @pre-commit-ci-lite
Add simple command history analyzer (#2163)
85e525a 
<img width="525" alt="image"
src="https://github.com/cursorless-dev/cursorless/assets/755842/fae1bdd3-470a-4c28-b2ef-e47818943b59">


## Checklist

- [ ] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [ ] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [ ] I have not broken the cheatsheet

---------

Co-authored-by: Pokey Rule <[email protected]>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
thetomcraig-aya pushed a commit to thetomcraig/cursorless that referenced this pull request Mar 27, 2024
@AndreasArvidsson @pokey
@pre-commit-ci-lite @cursorless-bot
Add simple command history analyzer (cursorless-dev#2163)
ff5d42a 
<img width="525" alt="image"
src="https://github.com/cursorless-dev/cursorless/assets/755842/fae1bdd3-470a-4c28-b2ef-e47818943b59">


## Checklist

- [ ] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [ ] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [ ] I have not broken the cheatsheet

---------

Co-authored-by: Pokey Rule <[email protected]>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pokey pokey pokey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndreasArvidsson @pokey