Added iteration scope for js statements #2144
Conversation
AndreasArvidsson
changed the title
| @@ -47,8 +45,14 @@ export function getScopeTestPaths() { | |||
| .filter((p) => p.endsWith(".scope")) | |||
| .map((p) => ({ | |||
| path: p, | |||
| name: path.relative(relativeDir, p.substring(0, p.lastIndexOf("."))), | |||
| name: pathToName(relativeDir, p), | |||
There was a problem hiding this comment.
Had forgot to update the name of scope test cases
| @@ -0,0 +1,33 @@ | |||
| // Start | |||
There was a problem hiding this comment.
Included to make it very obvious that it's not the function, but the entire document
| ifStatement: supported, | ||
| regularExpression: supported, | ||
| switchStatementSubject: supported, | ||
| fieldAccess: supported, | ||
|
|
||
| statement: supported, | ||
| "statement.iteration": supported, |
There was a problem hiding this comment.
This will absolutely get split up, and probably sooner rather than later. Should we do that now? Eg statement.iteration.file and statement.iteration.block? Tho block tends to mean something very different in our code base 🤔
There was a problem hiding this comment.
I was thinking about that, but there is no way to do separate scopes fixtures for that, both files will have 2 scopes I'm afraid.
Block is just the spoken form. We do call it paragraph as an id. I'm fine with block in this context.
There was a problem hiding this comment.
I was thinking about that, but there is no way to do separate scopes fixtures for that, both files will have 2 scopes I'm afraid.
Yeah I'm not sure of a way around that. But I still think making it super explicit what the iteration scopes should be is preferred
Block is just the spoken form. We do call it paragraph as an id. I'm fine with block in this context.
Sounds good
There was a problem hiding this comment.
Ok will split it!
Checklist