Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terser leading/trailing syntax in scm #2113

Merged
merged 5 commits into from
Dec 11, 2023
Merged

Conversation

AndreasArvidsson
Copy link
Member

Fixes #2108

Checklist

  • [-] I have added tests
  • [-] I have updated the docs and cheatsheet
  • [-] I have not broken the cheatsheet

Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow yeah way more readable

On an extremely minor note, I have very mixed feelings about the convention you're starting to introduce of functions that accept undefined on one of their params and return undefined in that case. Feels like it's conflating concerns. I tried rewriting it to use null-ish chaining and I think it worked well (f5dc428). I don't feel super strongly, so if you want to roll back that's fine, was just curious if it could be done with nullish chaining. If you do roll back, let's come up with a better name for that function. I think the convention could work if we come up with a solid naming convention to go along with it

@AndreasArvidsson AndreasArvidsson added this pull request to the merge queue Dec 11, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 11, 2023
@AndreasArvidsson AndreasArvidsson added this pull request to the merge queue Dec 11, 2023
Merged via the queue into main with commit ccc49a2 Dec 11, 2023
13 checks passed
@AndreasArvidsson AndreasArvidsson deleted the terseLeadingTrailing branch December 11, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terser leading/trailing syntax in scm
2 participants