Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate python scopes #2045

Merged
merged 9 commits into from
Nov 26, 2023
Merged

Migrate python scopes #2045

merged 9 commits into from
Nov 26, 2023

Conversation

AndreasArvidsson
Copy link
Member

@AndreasArvidsson AndreasArvidsson commented Nov 20, 2023 •
edited
Loading

Checklist

  • [-] I have added tests
  • [-] I have updated the docs and cheatsheet
  • [-] I have not broken the cheatsheet

@AndreasArvidsson AndreasArvidsson added lang-python Issues related to Python programming language support scope-migration Migrating scopes to next-gen scope implementation labels Nov 20, 2023
pokey
pokey reviewed Nov 22, 2023
View reviewed changes
Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with a few comments

packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/languages/python/clearCondition6.yml Outdated Show resolved Hide resolved
packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/languages/python/ditchCondition2.yml Outdated
Comment on lines 18 to 19
- anchor: {line: 1, character: 11}
active: {line: 1, character: 11}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

queries/python.scm Outdated Show resolved Hide resolved
packages/cursorless-engine/src/languages/python.ts Show resolved Hide resolved
packages/cursorless-engine/src/languages/python.ts Show resolved Hide resolved
queries/python.scm Outdated Show resolved Hide resolved
pokey
pokey approved these changes Nov 26, 2023
View reviewed changes
Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@pokey pokey added this pull request to the merge queue Nov 26, 2023
Merged via the queue into main with commit b70e87e Nov 26, 2023
13 checks passed
@pokey pokey deleted the python_scopes branch November 26, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pokey pokey pokey approved these changes

Assignees
No one assigned
Labels
lang-python Issues related to Python programming language support scope-migration Migrating scopes to next-gen scope implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndreasArvidsson @pokey