Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove jsx attribute from item scope #2039

Merged
merged 3 commits into from
Dec 5, 2023
Merged

Remove jsx attribute from item scope #2039

merged 3 commits into from
Dec 5, 2023

Conversation

AndreasArvidsson
Copy link
Member

@AndreasArvidsson AndreasArvidsson commented Nov 19, 2023 •
edited
Loading

Fixes #2034

Checklist

  • I have added tests
  • [-] I have updated the docs and cheatsheet
  • [-] I have not broken the cheatsheet

@AndreasArvidsson AndreasArvidsson added the lang-typescript TypeScript/JavaScript grammar support label Nov 19, 2023
pokey
pokey reviewed Nov 30, 2023
View reviewed changes
Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should prob ask on slack whether anyone is using this. Or maybe you already did that?

@AndreasArvidsson
Copy link
Member Author

AndreasArvidsson commented Nov 30, 2023 •
edited
Loading

We should prob ask on slack whether anyone is using this. Or maybe you already did that?

I have now!
https://talonvoice.slack.com/archives/C026KPTJE6T/p1701373644572159

pokey
pokey approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but please file an issue to track re-adding if there's not already one

packages/cursorless-engine/src/languages/html.ts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@AndreasArvidsson
Copy link
Member Author

I'm not completely sure if we actually want that? it's one of those things that if we overload a single scope to much it gets imprecise. I can make an issue about thinking about it :D

@AndreasArvidsson AndreasArvidsson added this pull request to the merge queue Dec 5, 2023
@AndreasArvidsson AndreasArvidsson mentioned this pull request Dec 5, 2023
Open
Merged via the queue into main with commit 8abc5a4 Dec 5, 2023
13 checks passed
@AndreasArvidsson AndreasArvidsson deleted the jsx_attribute branch December 5, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pokey pokey pokey approved these changes

Assignees
No one assigned
Labels
lang-html lang-typescript TypeScript/JavaScript grammar support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

comma based item broken inside of html attributes
2 participants
@AndreasArvidsson @pokey