Support mapping from key to VSCode command in Cursorless keyboard mode #2026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pokey
force-pushed
the
pokey/support-mapping-from-key-to-vscode-command-in-cursorless-keyboard-mode
branch
3 times, most recently
from
ebb881a to
1ad106d
Compare
|
ok @Kn0rk it has begun 😊 |
pokey
force-pushed
the
pokey/support-mapping-from-key-to-vscode-command-in-cursorless-keyboard-mode
branch
from
1ad106d to
dc4f6d3
Compare
pokey
commented
Nov 14, 2023
packages/cursorless-vscode/src/keyboard/KeyboardCommandsTargeted.ts
Outdated
Show resolved
Hide resolved
pokey
force-pushed
the
pokey/support-mapping-from-key-to-vscode-command-in-cursorless-keyboard-mode
branch
2 times, most recently
from
5558e8a to
76c2bf0
Compare
pokey
commented
Nov 14, 2023
Comment on lines
+100
to
+117
| "cursorless.experimental.keyboard.modal.keybindings.vscodeCommands": { | ||
| // For simple commands, just use the command name | ||
| // "aa": "workbench.action.editor.changeLanguageMode", | ||
|
|
||
| // For commands with args, use the following format | ||
| // "am": { | ||
| // "commandId": "some.command.id", | ||
| // "args": ["foo", 0] | ||
| // } | ||
|
|
||
| // If you'd like to run the command on the active target, use the following format | ||
| "am": { | ||
| "commandId": "editor.action.joinLines", | ||
| "executeAtTarget": true, | ||
| // "keepChangedSelection": true, | ||
| // "exitCursorlessMode": true, | ||
| } | ||
| } |
There was a problem hiding this comment.
@josharian @Kn0rk does this make sense?
There was a problem hiding this comment.
haven't taken it for a spin but reading it it makes sense
pokey
force-pushed
the
pokey/support-mapping-from-key-to-vscode-command-in-cursorless-keyboard-mode
branch
from
76c2bf0 to
71798a1
Compare
|
ok @AndreasArvidsson this one is ready for review. If you're happy, with it, let's give @Kn0rk and @josharian a chance for a quick look, as they've expressed interest in keyboard stuff (and supporting arbitrary VSCode commands was actually @Kn0rk's idea 😊) |
AndreasArvidsson
approved these changes
Nov 14, 2023
|
Looks good on a first glance. I will try to set it up on the weekend and give it a test drive. |
Sounds good; I'll keep stacking PRs off of this one and give you a branch to play with this weekend that has all my changes |
pokey
force-pushed
the
pokey/support-mapping-from-key-to-vscode-command-in-cursorless-keyboard-mode
branch
from
71798a1 to
c356f74
Compare
pokey
deleted the
pokey/support-mapping-from-key-to-vscode-command-in-cursorless-keyboard-mode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist