Move custom Object.keys() overload to util #2020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auscompgeek
commented
Nov 11, 2023
| @@ -52,7 +52,7 @@ export function getNodeMatcher( | |||
|
|
|||
| export const languageMatchers: Record< | |||
| LegacyLanguageId, | |||
| Record<SimpleScopeTypeType, NodeMatcher> | |||
| Partial<Record<SimpleScopeTypeType, NodeMatcher>> | |||
There was a problem hiding this comment.
See change in nodeMatchers.ts
| } | ||
| }); | ||
| return nodeMatchers as Record<SimpleScopeTypeType, NodeMatcher>; | ||
| ): Partial<Record<SimpleScopeTypeType, NodeMatcher>> { |
There was a problem hiding this comment.
Whilst I was here, figured I might as well remove the type assertion by using fromEntries. Turns out we were lying to TypeScript here; no guarantees every SimpleScopeTypeType will exist here at the end.
| @@ -159,7 +159,7 @@ async function runTest(file: string, spyIde: SpyIDE) { | |||
| ? undefined | |||
| : marksToPlainObject( | |||
| extractTargetedMarks( | |||
| Object.keys(fixture.finalState.marks) as string[], | |||
| Object.keys(fixture.finalState.marks), | |||
There was a problem hiding this comment.
Looks like this custom typing was really getting in the way 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2018
Checklist