Remove an import from cursorless-engine/src/util to src/processTargets. #2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pokey
reviewed
Nov 10, 2023
| @@ -1,4 +1,4 @@ | |||
| import { PlainTarget } from "../processTargets/targets"; | |||
| import { PlainTarget } from "../processTargets/targets/PlainTarget"; | |||
There was a problem hiding this comment.
As discussed, you should only switch from index file to direct import when both files are descendants of the folder containing the index file. This import could be what is breaking the build, because it subverts the barrel hack that we have to serialize the imports in target dir
|
I am revoking this PR, perhaps temporarily. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generally, code in src/utils should not be importing from src/processTargets. This cleans one instance of this up.
It also changes some imports from using the index.ts file to the direct file exporting the thing.
I do not think this will actually lead to a solution to the circular-import problem I'm having because ultimately there are still clearly circular file dependencies in this code, but removing the utils -> processTargets import still seems like a small improvement.