Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cheatsheet: Update ts-jest to 29.1.1 #2008

Merged
merged 1 commit into from
Nov 8, 2023
Merged

cheatsheet: Update ts-jest to 29.1.1 #2008

merged 1 commit into from
Nov 8, 2023

Conversation

auscompgeek
Copy link
Member

ts-jest did not officially support TypeScript 5.x until [email protected].

Also move jest to devDependencies whilst we're here.

Checklist

pokey
pokey approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Fwiw for marking checkboxes in description as not relevant, our convention is to put a - inside the [ ] so that the checkbox doesn't show as incomplete in PR list overview page. Also makes it easier to read the checkbox item text

image

@pokey pokey added this pull request to the merge queue Nov 8, 2023
Merged via the queue into main with commit bfac727 Nov 8, 2023
@pokey pokey deleted the bump-ts-jest branch November 8, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pokey pokey pokey approved these changes

@AndreasArvidsson AndreasArvidsson Awaiting requested review from AndreasArvidsson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@auscompgeek @pokey